• Too many global variables
  
• Misuse of the Hash class
  
• You wont be able to save your wood level when loading a game.
  

Code:

rand(6) + 1 # 1 - 6 inclusive
rand(6) # 0 - 6 exclusive
rand(7) # 0 - 6 inclusive


Code:

if woodcutting_lvl >= 1 && woodcutting_lvl <= 9
  #give character ( rand(4) + 1 ) for the number of items
end


Code:



if rand(100) == 0 # 1 in 100 chance
  #code
end

if rand(50) == 0 # 1 in 50 chance
  #code
end


Spoiler:

################################################################################
# Wood cutting system #
# #
# By: NuKa_BuBble #
# Version: 1.0 #
# Started: 29/08/2011 # #
# [You must be registered and logged in to see this link.] #
# # #
# #
################################################################################
# #
# No Graphics needed #
# #
################################################################################
# # #
# Instructions #
# # #
# In an event, add this part of script #
# if the player learned the job #
# $job_learn = true #
# #
# Call the script with #
# $Woodcutting.new #
# #
################################################################################

#------------------------------------------------------------------------------#
#------------------------------- NUKA module ----------------------------------#
#------------------------------------------------------------------------------#

module NUKA
#-------------Self Switch C is activated when a tree is cut--------------------#
SELF_SWITCH = $game_self_switches
SELF_SWITCH[key] = "C"

#-------------Woodcutting Stats------------------------------------------------#
woodcutting_exp = 0
woodcutting_lvl = 1
energie_rem = 100

#-------------The tools for woodcutting----------------------------------------#
WOODCUTTING_WPN_ID
{
6, 7
}
#-------------Other------------------------------------------------------------#
can_gain_wc_exp = true
LOGS_ID =
{
#Here, you can add logs ID in the item database for defferent logs type.
100, #It's a normal log
101,
102,
103,
104,
105,
106,
107,
108,
109
}


$tree_type = {
#(Value = tree_type) => item_ID
#The value is use for the xp multiplication
#Here, you add different type of tree for different logs.
1 => 100,
2 => 101,
3 => 102,
4 => 103,
5 => 104,
6 => 105,
7 => 106,
8 => 107,
9 => 108,
10 => 109
}

$job_learn = false
end
#------------------------------------------------------------------------------#
#---------------------------- End of the module -------------------------------#
#------------------------------------------------------------------------------#




#------------------------------------------------------------------------------#
#-------------------------- Class Woodcutting ---------------------------------#
#------------------------------------------------------------------------------#
class Woodcutting

#------------------------------------------------------------------------------#
# Initialize #
#------------------------------------------------------------------------------#
def initialize
@logs_gain = false
@logs_number
NUKA::LOGS_ID = $data[item_id]
@logs_ID = NUKA::LOGS_ID
@old_wc_lvl = 1
@wc_xp_gain
@wc_next_lvl
@i = 15

# If the logs type = to "A",
#the amount of gain xp is multiplied by the logs number and divided by 2.
@logs_type = {
A = 10,
B = 5,
C = 4,
D = 3,
E = 2,
F = 1.5
}

# (Can cut tree type)
# DO NOT TOUCH THIS PART OF CODE!
# Set the tree type that can be cut in the "CASE BLOCK"
@cctt = {}

end # end of initialize method

#--------------------------------------------------------------------------#
#------Define the tree type------------------------------------------------#
#--------------------------------------------------------------------------#
alias Woodcutting_logs_initialize initialize
def initialize(item_id)
Woodcutting_logs_initialize(item_id)
tree_type = 0
end

def tree_type
v = NUKA::$tree_type[@item_id]
n = v != nil ? v : v == nil ? 0 : 0
return n
end

Code:


{
#Here, you can add logs ID in the item database for defferent logs type.
100, #It's a normal log
101,
102,
103,
104,
105,
106,
107,
108,
109
}


Code:

# If the logs type = to "A",
#the amount of gain xp is multiplied by the logs number and divided by 2.
  @logs_type = {
  10,5,4,3,2,1.5
  }
  def logs_type_value
    if @logs_type = 10
      @logs_type = A
    else if @logs_type = 5
      @logs_type = B
    else if @logs_type = 4
      @logs_type = C
    else if @logs_type = 3
      @logs_type = D
    else if @logs_type = 2
      @logs_type = E
    else if @logs_type = 1.5
      @logs_type = F
  end
end

Code:

#----If the player cctt variables is equal or greater to 1, -------------------#
#----player can cut tree type 1------------------------------------------------#

if $tree_type = 1
  if @cctt >= 1
    can_cut = true
  end

else if $tree_type = 2
  if @cctt >= 2
    can_cut = true
  end

else if $tree_type = 3
  if @cctt >= 3
    can_cut = true
  end

else if $tree_type = 4
  if @cctt >= 4
    can_cut = true
  end

else if $tree_type = 5
  if @cctt >= 5
    can_cut = true
  end

else if $tree_type = 6
  if @cctt >= 6
    can_cut = true
  end

else if $tree_type = 7
  if @cctt >= 7
    can_cut = true
  end

else if $tree_type = 8
  if @cctt >= 8
    can_cut = true
  end

else if $tree_type = 9
  if @cctt >= 9
    can_cut = true
  end

else if $tree_type = 10
  if @cctt = 10
    can_cut = true
  end

else
  can_cut = false
end


Code:


class interpreter
def can_cut?(wood_level)
return ($game_party.wood_cut_level >= wood_level)
end
end


Code:


$woodcutting = Woodcutting.new


Code:


if @can_cut == true
  case woodcutting_lvl
  when 1..9
  @cctt = 1
  cut_tree = true
  @random = true
  when 10..19
  @cctt = 2
  cut_tree = true
  @random = true
  when 20..29
  @cctt = 3
  cut_tree = true
  @random = true
  when 30..39
  @cctt = 4
  cut_tree = true
  @random = true
  when 40..49
  @cctt = 5
  cut_tree = true
  @random = true
  when 50..59
  @cctt = 6
  cut_tree = true
  @random = true
  when 60..69
  @cctt = 7
  cut_tree = true
  @random = true
  when 70..79
  @cctt = 8
  cut_tree = true
  @random = true
  when 80..89
  @cctt = 9
  cut_tree = true
  @random = true
  when 90..100
  @cctt = 10
  cut_tree = true
  @random = true
  end
end


Code:


if @can_cut
  @cctt = (woodcutting_lvl / 10).ceil
  cut_tree = true
  @random = true
end


Code:


class Game_Party
def wood_level
return level
end
end


Code:

end #end of class woodcutting

class Game_Party < Woodcutting
def woodcutting
$game_party.woodcuttinglvl = woodcutting_lvl
end
end

Code:

class Game_Party < Game_Party
def woodcutting
$game_party.woodcuttinglvl = woodcutting_lvl
end
end

Code:

class Game_Party
def initialize
attr_accessor :woodcutting_lvl
lumbering = woodcutting_lvl
$game_party.lumbering
end
end

Code:


class Game_Party
  def initialize
    attr_accessor :woodcutting_lvl # <-----
    lumbering = woodcutting_lvl
    $game_party.lumbering
  end
end


Code:


class Game_Party
  attr_accessor :woodcutting_lvl # <-----

  def initialize
    lumbering = woodcutting_lvl
    $game_party.lumbering
  end
end


Code:


class Game_Party
  attr_accessor :woodcutting_lvl

  def initialize
    lumbering = woodcutting_lvl # <-----
    $game_party.lumbering
  end
end


Code:


class Game_Party
  attr_accessor :woodcutting_lvl

  def initialize
    @lumbering = woodcutting_lvl # <-----
    $game_party.lumbering
  end
end


Code:

def lumbering
@lumbering = woodcutting_lvl
end

Code:


class Game_Party
  attr_accessor :woodlvl
 
  alias :wood_init :initialize
  def initialize
    wood_init
    @woodlvl = 0
  end
end


Code:


class Game_Party
  attr_accessor :woodcutting_lvl
 
  alias :woodcutting_init :initialize
  def initialize
    woodcutting_init
    @lumbering = 0
    @lumbering = woodcutting_lvl
  end
end

mr_wiggles wrote:no you need to create the variable.

Code:


class Game_Party
  attr_accessor :woodlvl # <-----
 
  alias :wood_init :initialize
  def initialize
    wood_init
    @woodlvl = 0 # <-----
  end
end


something like that.

Code:

class Game_Party
  attr_accessor :woodcutting_lvl
 
  alias :lumbering_init :initialize
  def initialize
    lumbering_init
    @lumbering = 0
  end
end

[You must be registered and logged in to see this link.]
(19.54 Mb compress with winRAR)